Add local ffmpeg and MediaMTX builds to Docker #3353
Conversation
j0sh
force-pushed
the
ja/update-ffmpeg
branch
2 times, most recently
from
9bbcd73 to
6e253ee
Compare
j0sh
changed the title
This is needed in order to support Opus (enhanced RTMP)
j0sh
force-pushed
the
ja/update-ffmpeg
branch
from
6e253ee to
1e33cd7
Compare
j0sh
requested review from
victorges,
mjh1,
leszko,
hjpotter92 and
pwilczynskiclearcode
| && mv /opt/mediamtx/mediamtx /usr/local/bin/mediamtx \ | ||
| && mv /opt/mediamtx/mediamtx.yml /etc/mediamtx/mediamtx.yml \ | ||
| && rm -rf /opt/mediamtx/ | ||
| # Copy artifacts from the builder stage |
There was a problem hiding this comment.
since this is temporary, should we put the removed snippet as comments instead of deleting completely?
There was a problem hiding this comment.
and update the MEDIAMTX_VERSION with v1.11.2-livepeer-1 as we track that version field for alerts in deployments/version mismatches.
There was a problem hiding this comment.
I'm ok with still deleting, we have the git history to go back to. not really a big fan of commented out code
| @@ -30,6 +30,11 @@ RUN GRPC_HEALTH_PROBE_VERSION=v0.3.6 \ | |||
| && chmod +x /usr/bin/grpc_health_probe \ | |||
| && ldconfig /usr/local/lib | |||
|
|
|||
| RUN FFMPEG_SHA=b76053d8bf322b197a9d07bd27bbdad14fd5bc15 git clone --depth 1 https://git.ffmpeg.org/ffmpeg.git /ffmpeg \ | |||
There was a problem hiding this comment.
I thought we already had local ffmpeg for rtmp input and output 😕
https://github.com/livepeer/go-livepeer/blob/master/media/rtmp2segment.go#L59
There was a problem hiding this comment.
Oh I see now, you've removed the apt install and are compiling it instead
This is needed in order to support Opus (enhanced RTMP) for audio pass through.
The MediaMTX changes have been submitted upstream; hopefully they will get merged soon and we can go back to using off the shelf releases.